-
Notifications
You must be signed in to change notification settings - Fork 19
Update building mapping files with moab #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm able to create a mapping file (very quickly) with this approach but I'm having trouble remapping 2D data with it because the 2 dimensions have been flattened into 1 in the mapping file. The solution may be to flatten the 2D data before remapping. |
|
The fix for the mapping problem above is: |
|
Thanks to @vijaysm for the help! |
1329638 to
0ad0b47
Compare
|
I will get back to this in the coming week. |
TestingI successfully ran the following tests on Chrysalis: I also looked at the resulting Since ISOMIP+ is the only set of tests that currently uses this remapping functionality, I think that is sufficient testing for now. |
|
@bmooremaley, I know you're not really funded to work on Polaris or MOAB or anything related to this PR at the moment. I'm wondering if you'd take a quick look at the code even so and let me know if anything jumps out at you. If not, please approve so I can merge it. |
|
I'd like to move ahead with #151 (on hold for too long), which requires this work. So I'm going to go ahead and merge this. |
This merge reorganizes support for generating mapping files using MOAB's
mbtempestand related tools. This work relates to changes made by @bmooremaley in MPAS-Dev/compass#863.Checklist
Testingcomment in the PR documents testing used to verify the changes