Skip to content

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Nov 27, 2024

This merge reorganizes support for generating mapping files using MOAB's mbtempest and related tools. This work relates to changes made by @bmooremaley in MPAS-Dev/compass#863.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@xylar xylar added enhancement New feature or request framework Changes relating to the polaris framework as opposed to individual tests or analysis labels Nov 27, 2024
@xylar xylar requested a review from bmooremaley November 27, 2024 11:47
@xylar xylar self-assigned this Nov 27, 2024
@xylar
Copy link
Collaborator Author

xylar commented Nov 27, 2024

I'm able to create a mapping file (very quickly) with this approach but I'm having trouble remapping 2D data with it because the 2 dimensions have been flattened into 1 in the mapping file. The solution may be to flatten the 2D data before remapping.

@xylar
Copy link
Collaborator Author

xylar commented Dec 4, 2024

The fix for the mapping problem above is:
https://bitbucket.org/fathomteam/moab/branch/vijaysm/propagate-rll-dims

@xylar
Copy link
Collaborator Author

xylar commented Dec 4, 2024

Thanks to @vijaysm for the help!

@xylar
Copy link
Collaborator Author

xylar commented Feb 23, 2025

I will get back to this in the coming week.

@xylar xylar force-pushed the update-mbtempest branch from 0ad0b47 to 9d6797d Compare March 11, 2025 13:35
@xylar xylar marked this pull request as ready for review March 11, 2025 14:10
@xylar
Copy link
Collaborator Author

xylar commented Mar 11, 2025

Testing

I successfully ran the following tests on Chrysalis:

ocean/planar/isomip_plus/4km/z-star/ocean0
ocean/planar/isomip_plus/1km/z-star/ocean0

I also looked at the resulting topography_remapped.nc on the culled mesh in ParaView and things looked as expected.

Since ISOMIP+ is the only set of tests that currently uses this remapping functionality, I think that is sufficient testing for now.

@xylar
Copy link
Collaborator Author

xylar commented Mar 11, 2025

@bmooremaley, I know you're not really funded to work on Polaris or MOAB or anything related to this PR at the moment. I'm wondering if you'd take a quick look at the code even so and let me know if anything jumps out at you. If not, please approve so I can merge it.

@xylar xylar force-pushed the update-mbtempest branch from 9d6797d to 65a14f0 Compare March 11, 2025 19:34
@xylar xylar force-pushed the update-mbtempest branch from 65a14f0 to e732484 Compare March 24, 2025 15:18
@xylar xylar removed the request for review from bmooremaley March 25, 2025 14:12
@xylar
Copy link
Collaborator Author

xylar commented Mar 25, 2025

I'd like to move ahead with #151 (on hold for too long), which requires this work. So I'm going to go ahead and merge this.

@xylar xylar merged commit 91541b8 into E3SM-Project:main Mar 25, 2025
5 checks passed
@xylar xylar deleted the update-mbtempest branch March 25, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request framework Changes relating to the polaris framework as opposed to individual tests or analysis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant